chore: add --max-warnings 0 to all eslint runners and fix warnings #2447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=80&v=4){kind=small}
Co-Authored-By: Connor Prussin <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Connor Prussin <[email protected]>
cprussin
requested changes
Mar 6, 2025
apps/hermes/client/js/.eslintrc.js
Outdated
| parser: "@typescript-eslint/parser", | ||
| plugins: ["@typescript-eslint"], | ||
| extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended"], | ||
| rules: { |
There was a problem hiding this comment.
Please remove this and add eslint-ignore comments to lines where variables are intentionally ignored instead.
price_service/sdk/js/.eslintrc.js
Outdated
| extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended"], | ||
| rules: { | ||
| "@typescript-eslint/no-explicit-any": "off", | ||
| "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }] |
There was a problem hiding this comment.
Please remove this config, we can add eslint-ignore lines if there are any intentionally unused vars.
…tion Co-Authored-By: Connor Prussin <[email protected]>
cprussin
requested changes
Mar 6, 2025
Co-Authored-By: Connor Prussin <[email protected]>
cprussin
requested changes
Mar 6, 2025
There was a problem hiding this comment.
We also need to add --max-warnings 0 to the following jobs that were missed:
@pythnetwork/insights:test:lint:eslint@pythnetwork/component-library:test:lint:eslint
Will you also add --max-warnings 0 to the jobs that run stylelint as well:
@pythnetwork/insights:test:lint:stylelint@pythnetwork/component-library:test:lint:stylelint
Co-Authored-By: Connor Prussin <[email protected]>
cprussin
requested changes
Mar 6, 2025
…tend Co-Authored-By: Connor Prussin <[email protected]>
Co-Authored-By: Connor Prussin <[email protected]>
…sui.ts Co-Authored-By: Connor Prussin <[email protected]>
cprussin
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds --max-warnings 0 to all eslint runners in the repository and fixes any outstanding eslint warnings.
Changes made:
Link to Devin run: https://app.devin.ai/sessions/6663b90f3a1040cab837c75c8a11e769
Requested by: Connor